Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Beta] docs(cn): translate learn/javascript-in-jsx-with-curly-braces into Chinese #672

Merged
merged 6 commits into from
May 30, 2022

Conversation

flynn-eye
Copy link
Contributor

No description provided.

@flynn-eye flynn-eye force-pushed the javascript-in-jsx-with-curly-braces branch from a6372d4 to 739f949 Compare November 21, 2021 07:45
@QC-L QC-L changed the title docs(cn): translate learn/javascript-in-jsx-with-curly-braces into Chinese [Beta] docs(cn): translate learn/javascript-in-jsx-with-curly-braces into Chinese Nov 21, 2021
@QC-L QC-L mentioned this pull request Dec 7, 2021
@Megrax
Copy link
Contributor

Megrax commented Dec 8, 2021

hi @flynn-eye 麻烦看看 review 后的建议,更新一下 PR 吧,有觉得不合适的地方可以再讨论一下~

@flynn-eye
Copy link
Contributor Author

hi @flynn-eye 麻烦看看 review 后的建议,更新一下 PR 吧,有觉得不合适的地方可以再讨论一下~

好的

@flynn-eye
Copy link
Contributor Author

flynn-eye commented Dec 8, 2021

hi @flynn-eye 麻烦看看 review 后的建议,更新一下 PR 吧,有觉得不合适的地方可以再讨论一下~

按照建议已经修改好了 @Megrax

@Megrax
Copy link
Contributor

Megrax commented Dec 8, 2021

按照建议已经修改好了 @Megrax

呃...你好像只改了74行之前的?@flynn-eye
74行以及之后的好像还是没变啊:https://github.com/reactjs/zh-hans.reactjs.org/pull/672/files#diff-8bd85313f364f68f7cfeaf7d2582d66d7eb84d4aaa7cd0839b2ccaa2e56a9e43R74
🤣

@flynn-eye
Copy link
Contributor Author

按照建议已经修改好了 @Megrax

呃...你好像只改了74行之前的?@flynn-eye 74行以及之后的好像还是没变啊:https://github.com/reactjs/zh-hans.reactjs.org/pull/672/files#diff-8bd85313f364f68f7cfeaf7d2582d66d7eb84d4aaa7cd0839b2ccaa2e56a9e43R74 🤣

这次真改好了 @Megrax M 😵

Megrax
Megrax previously approved these changes Dec 10, 2021
@github-actions
Copy link

github-actions bot commented May 30, 2022

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/learn/javascript-in-jsx-with-curly-braces 51.69 KB (🟡 +822 B) 136.26 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants