Skip to content

Caution (in docs) against dispatching redux actions or triggering component updates by any other means in componentWillUpdate #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2017

Conversation

jedwards1211
Copy link
Contributor

(moving from facebook/react#9694)

…ponent updates by any other means in `componentWillUpdate`
@bvaughn
Copy link
Contributor

bvaughn commented Oct 8, 2017

I believe this corresponds with issue #74 😄

@reactjs-bot
Copy link

reactjs-bot commented Oct 8, 2017

Deploy preview ready!

Built with commit d5ebad1

https://deploy-preview-88--reactjs.netlify.com

Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jedwards1211! Thanks for the PR. As soon as the CLA-bot has confirmed that you've signed the CLA (https://code.facebook.com/cla) then this looks good to merge

@bvaughn bvaughn merged commit 5453a06 into reactjs:master Oct 9, 2017
@bvaughn
Copy link
Contributor

bvaughn commented Oct 9, 2017

Thanks!

jhonmike pushed a commit to jhonmike/reactjs.org that referenced this pull request Jul 1, 2020
Add brazilian portuguese translation to Legacy Factories warning article
BetterZxx pushed a commit to BetterZxx/react.dev that referenced this pull request Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants