Add stable fn notes to useMemo, useTransition, useState, and useReducer #7181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Mamaduka
reviewed
Sep 24, 2024
| }, [roomId]); // ✅ Only changes when roomId changes | ||
|
|
||
| useEffect(() => { | ||
| const options = createOptions(); |
There was a problem hiding this comment.
I think this is leftover from the useCallback example.
Mamaduka
reviewed
Sep 24, 2024
| const connection = createConnection(options); | ||
| connection.connect(); | ||
| return () => connection.disconnect(); | ||
| }, [options]); // ✅ Only changes when createOptions changes |
There was a problem hiding this comment.
// ✅ Only changes when cached
optionsobject changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useCallbackhas this, but notuseState,useReducer,useMemo, oruseTransition.