Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning page for RTR deprecation #6632

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Conversation

jackpope
Copy link
Collaborator

To be linked from future warning messages

Copy link

vercel bot commented Feb 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
react-dev ✅ Ready (Inspect) Visit Preview Feb 15, 2024 9:16pm

Copy link

github-actions bot commented Feb 15, 2024

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌


react-test-renderer is deprecated. A warning will fire whenever calling ReactTestRenderer.create() or ReactShallowRender.render(). The react-test-renderer package will remain available on NPM but will not be maintained and may break with new React features or changes to React's internals.

The React Team recommends migrating your tests to [@testing-library/react](https://testing-library.com/docs/react-testing-library/intro/) for a modern and well supported testing experience.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we link to react-native-testing-library here as well so that people don't get the impression RNTL is implicitly deprecated?

Copy link
Collaborator Author

@jackpope jackpope Feb 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add the link to clarify. We're going to come back to this messaging soon once we've agreed upon the plan going forward. And we may have separate warnings in RN for introspection API usage rather than during create/render.

@jackpope jackpope merged commit bce6e55 into reactjs:main Feb 15, 2024
4 checks passed
@jackpope jackpope deleted the rtr-warning branch February 15, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants