Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Prettier line-width for example JS #600

Closed

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Feb 7, 2018

Builds on top of PR #596. (I made this a separate PR since all of the modifications were automated.)

This significantly improves the readability of JS examples on Desktop. It causes some line-wrapping on smaller mobile devices (screenshots below) but I think the code is still readable there.

screen shot 2018-02-07 at 8 20 07 am

screen shot 2018-02-07 at 8 20 16 am

@bvaughn bvaughn requested a review from gaearon February 7, 2018 16:22
@reactjs-bot
Copy link

Deploy preview for reactjs ready!

Built with commit 5997700

https://deploy-preview-600--reactjs.netlify.com

@gaearon
Copy link
Member

gaearon commented Feb 7, 2018

(This would need to be merged into your branch, right?)

@bvaughn
Copy link
Contributor Author

bvaughn commented Feb 7, 2018

Yeah, I plan on merging all 3 of these branches (the two blog posts and now this one) before merging, because I need to cross-link them and stuff.

@gaearon
Copy link
Member

gaearon commented Feb 7, 2018

Another option is to apply this on top of master separately. Then rebasing those PRs on top.

@bvaughn bvaughn closed this Feb 7, 2018
@bvaughn bvaughn deleted the update-on-async-rendering-part-2 branch February 7, 2018 17:23
@bvaughn bvaughn mentioned this pull request Feb 7, 2018
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants