Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed createBlockingRoot API docs and added a warning note #3642

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Apr 19, 2021

Follow up to facebook/react#21316

@eps1lon
Copy link
Collaborator

eps1lon commented Apr 19, 2021

Want to remove timeoutMS as well while you're at it (facebook/react#19703)? 😄

@bvaughn
Copy link
Contributor Author

bvaughn commented Apr 19, 2021

Nope 😆 Sorry this was just a quick bandaid fix

@eps1lon
Copy link
Collaborator

eps1lon commented Apr 19, 2021

Nope Sorry this was just a quick bandaid fix

Ok, I just looked for every mention of timeoutMS and it does look a bit more involved. I don't know enough about the current semantics to update sections such as

If we make our API responses take 5 seconds, we can confirm that now React "gives up" and transitions anyway to the next screen after 3 seconds. This is because we passed {timeoutMs: 3000} to useTransition(). For example, if we passed {timeoutMs: 60000} instead, it would wait a whole minute.

@gaearon
Copy link
Member

gaearon commented Apr 19, 2021

The plan is to nix these docs before the release in favor of much more focused ones so I wouldn’t worry about updating them.

Copy link
Member

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine but a lot of other things are outdated too so I don’t know that this one needs special treatment

@bvaughn
Copy link
Contributor Author

bvaughn commented Apr 19, 2021

True! I only proposed this because it seemed to cause confusion but I don't feel strongly one way or another.

@bvaughn bvaughn merged commit 8e0ed8f into reactjs:master Apr 19, 2021
@bvaughn bvaughn deleted the remove-createBlockingRoot branch April 19, 2021 21:01
@reactjs-bot
Copy link

Deploy preview for reactjs ready!

Built with commit 05a760b

https://deploy-preview-3642--reactjs.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants