Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #25 - added warning to documentation #116

Merged
merged 1 commit into from
Oct 16, 2017
Merged

Fixes #25 - added warning to documentation #116

merged 1 commit into from
Oct 16, 2017

Conversation

fumblehool
Copy link
Contributor

@facebook-github-bot
Copy link
Collaborator

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@reactjs-bot
Copy link

Deploy preview ready!

Built with commit 2f21bc0

https://deploy-preview-116--reactjs.netlify.com

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@bvaughn
Copy link
Contributor

bvaughn commented Oct 10, 2017

Maybe @sebmarkbage (or someone else that has more context on SSR+hydration) can review this PR to make sure it's sufficient.

@dustinsoftware
Copy link
Member

Thanks! This warning is what I had in mind :)

Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable then. I'll merge it and Seb can always tweak it in a follow up. 😄

@bvaughn bvaughn merged commit f9a15e9 into reactjs:master Oct 16, 2017
@sebmarkbage
Copy link
Contributor

It's a bit confusing wording because the missing nodes won't get the wrong attributes, it's the other nodes that might get the wrong attributes if one sibling is missing.

@bvaughn
Copy link
Contributor

bvaughn commented Oct 16, 2017

Thanks for weighing in @sebmarkbage. Would this be an improvement?

However, it's dangerous to have missing nodes on the server render as this might cause sibling nodes to be created with incorrect attributes.

@sebmarkbage
Copy link
Contributor

Sounds good

@bvaughn
Copy link
Contributor

bvaughn commented Oct 16, 2017

Cool beans. Changed in 8acec80. Thanks again!

jhonmike pushed a commit to jhonmike/reactjs.org that referenced this pull request Jul 1, 2020
* Update reference-test-renderer.md

* Update reference-test-renderer.md

* Update reference-test-renderer.md

* Update reference-test-renderer.md

* Update reference-test-renderer.md

* Update reference-test-renderer.md

* Update content/docs/reference-test-renderer.md

* Update content/docs/reference-test-renderer.md

* Update content/docs/reference-test-renderer.md

* Update content/docs/reference-test-renderer.md

* Update reference-test-renderer.md

* Update reference-test-renderer.md

* instantâneo -> snapshot

* instantâneo -> snapshot

* Update content/docs/reference-test-renderer.md

Co-Authored-By: fjoshuajr <[email protected]>

* Update content/docs/reference-test-renderer.md

Co-Authored-By: fjoshuajr <[email protected]>

* Update content/docs/reference-test-renderer.md

Co-Authored-By: fjoshuajr <[email protected]>
BetterZxx pushed a commit to BetterZxx/react.dev that referenced this pull request Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants