-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #25 - added warning to documentation #116
Conversation
fumblehool
commented
Oct 10, 2017
- Fixes Document that you can't rely on React 16 SSR patching up differences #25
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Deploy preview ready! Built with commit 2f21bc0 |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Maybe @sebmarkbage (or someone else that has more context on SSR+hydration) can review this PR to make sure it's sufficient. |
Thanks! This warning is what I had in mind :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable then. I'll merge it and Seb can always tweak it in a follow up. 😄
It's a bit confusing wording because the missing nodes won't get the wrong attributes, it's the other nodes that might get the wrong attributes if one sibling is missing. |
Thanks for weighing in @sebmarkbage. Would this be an improvement?
|
Sounds good |
Cool beans. Changed in 8acec80. Thanks again! |
* Update reference-test-renderer.md * Update reference-test-renderer.md * Update reference-test-renderer.md * Update reference-test-renderer.md * Update reference-test-renderer.md * Update reference-test-renderer.md * Update content/docs/reference-test-renderer.md * Update content/docs/reference-test-renderer.md * Update content/docs/reference-test-renderer.md * Update content/docs/reference-test-renderer.md * Update reference-test-renderer.md * Update reference-test-renderer.md * instantâneo -> snapshot * instantâneo -> snapshot * Update content/docs/reference-test-renderer.md Co-Authored-By: fjoshuajr <[email protected]> * Update content/docs/reference-test-renderer.md Co-Authored-By: fjoshuajr <[email protected]> * Update content/docs/reference-test-renderer.md Co-Authored-By: fjoshuajr <[email protected]>
…reactjs#116) 大佬们再 Review Review ~