Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add componentDidCatch to React.Component page #120

Closed
bvaughn opened this issue Oct 10, 2017 · 10 comments
Closed

Add componentDidCatch to React.Component page #120

bvaughn opened this issue Oct 10, 2017 · 10 comments

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Oct 10, 2017

Add componentDidCatch to https://reactjs.org/docs/react-component.html and link to https://reactjs.org/blog/2017/07/26/error-handling-in-react-16.html for a more complete explanation.

@cyan33
Copy link
Contributor

cyan33 commented Oct 11, 2017

Can I try this? I really love this newly brought feature in React16! :)

@bvaughn
Copy link
Contributor Author

bvaughn commented Oct 11, 2017

Sure! This issue is all yours! 😄

I've added an "in-progress" label so that others will know not to start work on the issue. If you change your mind about the issue, no worries! Just let me know so that I can remove the label and free it up for someone else to claim.

Cheers!

@cyan33
Copy link
Contributor

cyan33 commented Oct 11, 2017

@bvaughn Hi, thanks for giving me this opportunity. I've added all the necessary document. But right now I'm having a problem on referencing that blog post in the document markdown. Could you please help me with that?

This is how I tried but it redirects to the bottom of the new page.

For more details, check [*Error Handling in React 16*](../blog/2017/07/26/error-handling-in-react-16.html).

@bvaughn
Copy link
Contributor Author

bvaughn commented Oct 11, 2017

You should be able to link to /blog/2017/07/26/error-handling-in-react-16.html (no leading "../")

@cyan33
Copy link
Contributor

cyan33 commented Oct 11, 2017

Thanks Brian. 😄

@bvaughn
Copy link
Contributor Author

bvaughn commented Oct 11, 2017

Closed via #136
Thanks!

@bvaughn bvaughn closed this as completed Oct 11, 2017
@merlinstardust
Copy link

I would like to see this expanded to include better docs about info. Came here through a trail from facebook/react#10461 - decompose info parameter.

I would do it but the only part I am aware of is componentStack. Are there more keys?

@bvaughn
Copy link
Contributor Author

bvaughn commented May 31, 2018

componentStack is the only current key.

This is mentioned here:
https://reactjs.org/docs/error-boundaries.html#componentdidcatch-parameters

But yea, we should either cross-link or expand in the Component API page too.

@merlinstardust
Copy link

What future keys do you plan to add to info?

@bvaughn
Copy link
Contributor Author

bvaughn commented May 31, 2018

No plans / unknown

BetterZxx pushed a commit to BetterZxx/react.dev that referenced this issue Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants