Feature/add custom active and disabled class #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selvagsz
changed the title
selvagsz
changed the title
src/components/Tab.js
Outdated
| 'ReactTabs__Tab--selected': selected, | ||
| 'ReactTabs__Tab--disabled': disabled, | ||
| [`${activeTabClassName}`]: selected, | ||
| [`${disabledTabClassName}`]: disabled, |
Collaborator
There was a problem hiding this comment.
I think we could just do [activeTabClassName]: selected without template string?
Collaborator
|
Thanks for contributing. If you could fix the two small issues I can merge it. |
selvagsz
force-pushed
the
feature/add_custom_active_and_disabled_class
branch
from
789ee5b to
d0b5186
Compare
Contributor
Author
|
@danez done 👍 |
Contributor
Author
|
@danez Anything else needs to be done ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be very useful, mainly when we work with CSS frameworks like bootstrap
Closes #65