Skip to content

Conversation

@wiredprairie
Copy link

I wanted a way to use the Harmony command line switch automatically from Rails. I've added it as a simple option:

MyApp::Application.configure do
  config.react.harmony = true
end

I also included a simple test case.

@brentvatne
Copy link
Member

👍 for this feature

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if we ever made any formal declaration that we don't support Ruby 1.8. I think all of our other hash uses continue with the rocket syntax.

Additionally, we should just make harmony an option to the transform function (or better, take an options hash) instead of relying on a global config like this.

@zpao
Copy link
Member

zpao commented Dec 22, 2014

@wiredprairie I take it you don't want to continue this? Thanks for starting the effort!

@wiredprairie
Copy link
Author

I switched away from Rails shortly after I made the pull request ... and
don't have time to make any changes like you suggested.

On 12/22/2014 4:35 PM, Paul O’Shannessy wrote:

@wiredprairie https://github.com/wiredprairie I take it you don't
want to continue this? Thanks for starting the effort!


Reply to this email directly or view it on GitHub
#107 (comment).

@zpao
Copy link
Member

zpao commented Dec 29, 2014

@wiredprairie Fair enough & thanks again for getting this started!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants