feat(resolve): resolve Object.keys() in PropType.oneOf() #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creates a new util to extract keys from ObjectExpressions.
This does not ignore setters, but deduplicate the resolved entries and makes them unique.
|
Hello, anybody can merge this pr to v3-dev branch? |
|
It would be great if this could be done for |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a new util to extract keys from
Object.keys()andObjectExpressionswhen used inside ofoneOf()It also follows spreads and tries to resolve them. Currently it bails out if either a
Propertyis computed and the computed key is not aLiteralor if a spread cannot be resolved.Getters will be handled the same as normal properties, but setters will be ignored. Not sure if this makes 100% sense, but this can be easily changed.
This fixes #153.
As a follow up the same can be done easily for
Object.values.!! When this gets merged to v3,
SpreadPropertyneeds to be replaced withSpreadElement!!