Skip to content

Conversation

@wallaroo
Copy link
Contributor

hi,
i added a cli parameter 'exclude' to confugure some filename patterns from parsing.
the default is set to ['index.js'] because is a common use to organize components in indexed namespaces
Es.

/package.json
/app.js
/components/
/components/namespace1/index.js
/components/namespace1/Component1.js
/components/namespace1/Component2.js

where index.js is:

export Component1 from './Component1'
export Component2 from './Component2'

and app.js imports these components with:
import {Component1, Component2} from './components/namespace1'

i know that someone use the pattern /components/ComponentName/index.js (i don't like this) so... maybe is better to set [] as default...

@fkling
Copy link
Member

fkling commented Aug 2, 2016

That's great, thank you! Yeah, I think we should leave the default empty, otherwise this would be a breaking change.

@dptoot
Copy link

dptoot commented Aug 12, 2016

Definitely looking forward to this being added. Any chance this can get added into the next release?

@fkling
Copy link
Member

fkling commented Aug 12, 2016

@dptoot , @wallaroo just needs to remove the default value and this should be good to go 😃

@wallaroo
Copy link
Contributor Author

sorry for the late React...ion ;-)

@fkling fkling merged commit bfa26d4 into reactjs:master Aug 22, 2016
@wallaroo wallaroo deleted the develop branch August 23, 2016 08:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants