Extracted flow 0.53 props from react component are not recognized

[danrot]

I have just changed our codebase to the new flow types for React (meaning to use stuff as described here).

So my react classes now look like that:

type Props = {
    value: boolean,
};

class MyComponent extends React.Component<Props> {
    // ...
}

These props are then not recognized by the library anymore... I am using version 2.17.0.

[rosskevin]

Please change the title to something referencing Flow 53, hopefully this will get everyone's attention

[danrot]

@rosskevin Changed it, but I doubt that this helps...

[fkling]

That's an easy fix.

react-docgen/src/utils/getFlowTypeFromReactComponent.js

Line 35 in 760c426

typePath = superTypes.get('params').get(1);

should be instead

typePath = superTypes.get('params').get(0);

Thank you for opening the issue!

[danrot]

Do you want me to fix it, or do you do it on your own?

[danez]

Feel free to make a PR.

We should also make sure it works also with old and new flow versions.

something like this.

const params = superTypes.get('params');
if (params.value.length === 3) {
  typePath = params.get(1);
} else {
 typePath = params.get(0);
}

[danez]

I created a PR which fixes this #209