This repository has been archived by the owner on Jul 19, 2019. It is now read-only.
[changed] Prevent Return in menu from submitting surrounding form
#92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default behaviour of hitting `Return` in a `<input type=text>` is to submit the immediate surrounding form. I would hazard a guess that this isn't the expected result when using `Return` to select an item in the autocomplete menu. Since we don't expose the event object to the consumer via `onSelect` we need to make sure we're making the most sensible choice by default. Hitting `Return` a second time (after the menu has closed itself) will result in the default, expected behaviour.
|
Looks good! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behaviour of hitting
Returnin a<input type=text>is to submitthe immediate surrounding form. I would hazard a guess that this isn't the
expected result when using
Returnto select an item in the autocompletemenu. Since we don't expose the event object to the consumer via
onSelectweneed to make sure we're making the most sensible choice by default.
Hitting
Returna second time (after the menu has closed itself) willresult in the default, expected behaviour.