This repository has been archived by the owner on Jul 19, 2019. It is now read-only.
[fixed] Select highlighted item on input click #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While trying to debug reactjs#80 I discovered that clicking the input field to "confirm" a suggestion didn't work as expected. The problem: 1. Navigate to https://reactcommunity.org/react-autocomplete/static-data/ 2. Type 'a' in input field 3. Observe that the input has been filled with 'Alabama' 4. Click anywhere inside the input field 5. Observe that the highlighted selection is gone, and the menu has been closed 6. Click/tab outside the input 7. Observe that the input value has been reverted to 'a' This change ensures that clicking in the input field has the same effect as clicking the highlighted item in the suggestion menu.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to debug #80 I discovered that clicking the input field to
"confirm" a suggestion didn't work as expected.
The problem:
This change ensures that clicking in the input field has the same effect as
clicking the highlighted item in the suggestion menu.