This repository has been archived by the owner on Jul 19, 2019. It is now read-only.
[fixed] Prevent autocomplete when clicking a non-focusable input #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to prevent autocomplete from happening when clicking a disabled input field. The `ownerDocument` check is paranoid since I couldn't find any documentation as to when support was added to WebKit/Blink. It's in the DOM level 2 spec, so support should be widespread. The alternative to this fix is to explicitly check `input.disabled`. http://quirksmode.org/dom/core/#t136 https://developer.mozilla.org/en-US/docs/Web/API/Node/ownerDocument
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to prevent autocomplete from happening when clicking a disabled input
field.
The
ownerDocumentcheck is paranoid since I couldn't find any documentationas to when support was added to WebKit/Blink. It's in the DOM level 2 spec, so
support should be widespread.
The alternative to this fix is to explicitly check
input.disabled.http://quirksmode.org/dom/core/#t136
https://developer.mozilla.org/en-US/docs/Web/API/Node/ownerDocument