Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Thinking in React #83

Merged
merged 7 commits into from
Feb 14, 2019
Merged

Translate Thinking in React #83

merged 7 commits into from
Feb 14, 2019

Conversation

rafaelquintanilha
Copy link
Contributor

No description provided.

@fjoshuajr fjoshuajr added the needs review A pull request ready to be reviewed label Feb 11, 2019
thadeu
thadeu reviewed Feb 12, 2019
View reviewed changes
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Show resolved Hide resolved
thadeu
thadeu suggested changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@thadeu thadeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rafaelquintanilha

@thadeu @rafaelquintanilha
Update content/docs/thinking-in-react.md
5dfddde 
Review feedback

Co-Authored-By: rafaelquintanilha <[email protected]>
@eduardomoroni eduardomoroni added needs author response Changes requested needing author's input needs +1 Needs another approval before merging and removed needs review A pull request ready to be reviewed labels Feb 12, 2019
gabrielbs
gabrielbs reviewed Feb 12, 2019
View reviewed changes
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Show resolved Hide resolved
gabrielbs
gabrielbs previously approved these changes Feb 12, 2019
View reviewed changes
@cezaraugusto cezaraugusto added feedback addressed and removed needs +1 Needs another approval before merging needs author response Changes requested needing author's input labels Feb 13, 2019
fjoshuajr
fjoshuajr requested changes Feb 13, 2019
View reviewed changes
Copy link
Collaborator

@fjoshuajr fjoshuajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Estamos quase lá @rafaelquintanilha

content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Show resolved Hide resolved
@fjoshuajr fjoshuajr added needs author response Changes requested needing author's input and removed feedback addressed labels Feb 13, 2019
@rafaelquintanilha
Copy link
Contributor Author

@fjoshuajr should be good now

@fjoshuajr fjoshuajr added needs +1 Needs another approval before merging and removed needs author response Changes requested needing author's input labels Feb 14, 2019
fjoshuajr
fjoshuajr approved these changes Feb 14, 2019
View reviewed changes
Copy link
Collaborator

@fjoshuajr fjoshuajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

glaucia86
glaucia86 approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rafaelquintanilha

LGTM 👍
Muito obrigada pela sua contribuição. :)

@glaucia86 glaucia86 merged commit 6ef42c2 into reactjs:master Feb 14, 2019
@tesseralis tesseralis mentioned this pull request Feb 14, 2019
Closed
90 tasks
@glaucia86 glaucia86 added 🌐 translated Translation is completed for this page and removed needs +1 Needs another approval before merging labels Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallycarvalho wallycarvalho wallycarvalho left review comments

@thadeu thadeu thadeu requested changes

@fjoshuajr fjoshuajr fjoshuajr approved these changes

@glaucia86 glaucia86 glaucia86 approved these changes

@gabrielbs gabrielbs gabrielbs left review comments

Assignees

@fjoshuajr fjoshuajr

Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@rafaelquintanilha @thadeu @glaucia86 @gabrielbs @fjoshuajr @wallycarvalho @eduardomoroni @cezaraugusto