Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate React without JSX #56

Merged
merged 5 commits into from
Feb 10, 2019
Merged

Translate React without JSX #56

merged 5 commits into from
Feb 10, 2019

Conversation

tibuurcio
Copy link
Collaborator

No description provided.

@tibuurcio tibuurcio added the needs review A pull request ready to be reviewed label Feb 10, 2019
fjoshuajr
fjoshuajr previously requested changes Feb 10, 2019
View reviewed changes
Copy link
Collaborator

@fjoshuajr fjoshuajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the comments, please.

content/docs/react-without-jsx.md Show resolved Hide resolved
content/docs/react-without-jsx.md Outdated Show resolved Hide resolved
content/docs/react-without-jsx.md Outdated Show resolved Hide resolved
@fjoshuajr fjoshuajr added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Feb 10, 2019
@tibuurcio tibuurcio added needs review A pull request ready to be reviewed needs +1 Needs another approval before merging and removed needs author response Changes requested needing author's input needs review A pull request ready to be reviewed labels Feb 10, 2019
glaucia86
glaucia86 requested changes Feb 10, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tibuurcio

Algumas alterações a serem feitas. Pedimos que faça os ajustes e logo iremos aprovar a sua contribuição.
Pedimos que, conforme for realizando os acertos que marque como 'Resolve Conversation' e nos sinalize para que possamos analisar novamente a tradução e enfim, aprovar o seu PR. Muito obrigada!

content/docs/react-without-jsx.md Show resolved Hide resolved
content/docs/react-without-jsx.md Show resolved Hide resolved
content/docs/react-without-jsx.md Outdated Show resolved Hide resolved
content/docs/react-without-jsx.md Outdated Show resolved Hide resolved
@glaucia86 glaucia86 added needs author response Changes requested needing author's input and removed needs +1 Needs another approval before merging labels Feb 10, 2019
@glaucia86
Copy link
Member

@tibuurcio

Algumas alterações a serem feitas. Pedimos que faça os ajustes e logo iremos aprovar a sua contribuição.
Pedimos que, conforme for realizando os acertos que marque como 'Resolve Conversation' e nos sinalize para que possamos analisar novamente a tradução e enfim, aprovar o seu PR. Muito obrigada!

Assim que você concluir as suas mudanças, marque como 'Resolve Conversation' e altere para a label: 'changes already resolved it - translator'.
Muito obrigada pela sua contribuição! 😄

@tibuurcio tibuurcio added needs resolution Something not defined that needs maintainers input feedback addressed and removed needs author response Changes requested needing author's input needs resolution Something not defined that needs maintainers input labels Feb 10, 2019
glaucia86
glaucia86 approved these changes Feb 10, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

cc: @cezaraugusto @fjoshuajr só aprovar

@glaucia86
Copy link
Member

@tibuurcio

Queremos agradecer pela sua excelente contribuição! Muito obrigada!

@glaucia86 glaucia86 added needs +1 Needs another approval before merging and removed feedback addressed labels Feb 10, 2019
cezaraugusto
cezaraugusto approved these changes Feb 10, 2019
View reviewed changes
Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@cezaraugusto cezaraugusto dismissed fjoshuajr’s stale review February 10, 2019 15:47

feedback addressed

@cezaraugusto cezaraugusto merged commit 8a1c07f into reactjs:master Feb 10, 2019
@cezaraugusto cezaraugusto added 🌐 translated Translation is completed for this page and removed needs +1 Needs another approval before merging labels Feb 10, 2019
@tesseralis tesseralis mentioned this pull request Feb 10, 2019
Closed
90 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cezaraugusto cezaraugusto cezaraugusto approved these changes

@glaucia86 glaucia86 glaucia86 approved these changes

@fjoshuajr fjoshuajr fjoshuajr left review comments

Assignees
No one assigned
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tibuurcio @glaucia86 @cezaraugusto @fjoshuajr