Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReactDOM page translation #48

Merged
merged 5 commits into from
Feb 11, 2019
Merged

ReactDOM page translation #48

merged 5 commits into from
Feb 11, 2019

Conversation

michellocana
Copy link
Contributor

No description provided.

@fjoshuajr fjoshuajr added the needs review A pull request ready to be reviewed label Feb 9, 2019
glaucia86
glaucia86 requested changes Feb 10, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michellocana

Nós não suportamos navegadores antigos que não suportam métodos ES5, mas você pode descobrir que suas aplicações funcionam em navegadores antigos se polyfills como es5-shim and es5-sham forem incluídos na página. Você está por sua conta se optar por seguir esse caminho.

content/docs/reference-react-dom.md Outdated Show resolved Hide resolved
@glaucia86 glaucia86 added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Feb 10, 2019
@glaucia86
Copy link
Member

@michellocana

Algumas alterações a serem feitas. Pedimos que faça os ajustes e logo iremos aprovar a sua contribuição.
Pedimos que, conforme for realizando os acertos que marque como 'Resolve Conversation' e nos sinalize para que possamos analisar novamente a tradução e enfim, aprovar o seu PR. Muito obrigada!

Assim que você concluir as suas mudanças, marque como 'Resolve Conversation' e altere para a label: 'changes already resolved it - translator'.
Muito obrigada pela sua contribuição! 😄

rafael-vitor and others added 2 commits February 10, 2019 09:41
@rafael-vitor @michellocana
Fixing translation
cd84df8 
Co-Authored-By: michellocana <[email protected]>
@rafael-vitor @michellocana
Fixing hydrate section translation
f76441c 
Co-Authored-By: michellocana <[email protected]>
@tesseralis tesseralis mentioned this pull request Feb 10, 2019
Closed
90 tasks
@michellocana
Copy link
Contributor Author

@rafael-vitor @glaucia86 obrigado pelas sugestões, fiz os ajustes necessários 😁

@glaucia86 fiz um pequeno ajuste na sua sugestão, na expressão "por conta e risco"

@WendellAdriel WendellAdriel added feedback addressed and removed needs author response Changes requested needing author's input labels Feb 11, 2019
glaucia86
glaucia86 previously approved these changes Feb 11, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@glaucia86 glaucia86 added needs +1 Needs another approval before merging and removed feedback addressed labels Feb 11, 2019
fjoshuajr
fjoshuajr approved these changes Feb 11, 2019
View reviewed changes
Copy link
Collaborator

@fjoshuajr fjoshuajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨✨

@fjoshuajr fjoshuajr added 🌐 translated Translation is completed for this page and removed needs +1 Needs another approval before merging labels Feb 11, 2019
@fjoshuajr
Copy link
Collaborator

LGTM 👍

Vou fazer merge ✌

@fjoshuajr fjoshuajr merged commit 14ce6fe into reactjs:master Feb 11, 2019
@michellocana michellocana changed the title ReactDOM page translation WIP: ReactDOM page translation Feb 11, 2019
@michellocana michellocana changed the title WIP: ReactDOM page translation ReactDOM page translation Feb 11, 2019
@michellocana
Copy link
Contributor Author

@fjoshuajr acabei de ver um "component" na mesma frase que tu ajustou, mas agora que foi dado merge, acho que posso fazer uma PR separada como fix

@fjoshuajr
Copy link
Collaborator

fjoshuajr commented Feb 11, 2019 •
edited
Loading

Sim @michellocana, pode fazer um PR.

Vou aprovar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafael-vitor rafael-vitor rafael-vitor left review comments

@fjoshuajr fjoshuajr fjoshuajr approved these changes

@glaucia86 glaucia86 glaucia86 left review comments

Assignees
No one assigned
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@michellocana @glaucia86 @fjoshuajr @rafael-vitor @WendellAdriel