Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate CodeEditor #20

Merged
merged 4 commits into from
Feb 9, 2019
Merged

Translate CodeEditor #20

merged 4 commits into from
Feb 9, 2019

Conversation

abnersajr
Copy link
Contributor

This PR references issue #1 translating the CodeEditor component.

@fjoshuajr
Copy link
Collaborator

Working fast @abnersajr 👍

fjoshuajr
fjoshuajr previously requested changes Feb 8, 2019
View reviewed changes
Copy link
Collaborator

@fjoshuajr fjoshuajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check those

src/components/CodeEditor/CodeEditor.js Outdated Show resolved Hide resolved
src/components/CodeEditor/CodeEditor.js Outdated Show resolved Hide resolved
src/components/CodeEditor/CodeEditor.js Outdated Show resolved Hide resolved
@fjoshuajr fjoshuajr added the needs review A pull request ready to be reviewed label Feb 8, 2019
@abnersajr
Copy link
Contributor Author

I've accepted all the requests. Thank you @fjoshuajr for those catches.

glaucia86
glaucia86 approved these changes Feb 8, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

cc: @fjoshuajr @cezaraugusto could you see this PR if it's okay?

cezaraugusto
cezaraugusto reviewed Feb 9, 2019
View reviewed changes
src/components/CodeEditor/CodeEditor.js
This can be caused by an ad blocker. If you're using one, consider
adding reactjs.org to the whitelist so the live code examples will
work.
Isto pode ser causado por algum bloqueador de anúncio. Se você está usando algum, considere adicionar o endereço reactjs.org na <i>whitelist</i>, ou lista de permitidos, e feito isso os exemplos com <i>live code</i> irão funcionar.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adblock FTW

cezaraugusto
cezaraugusto approved these changes Feb 9, 2019
View reviewed changes
Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ thanks @abnersajr

@cezaraugusto cezaraugusto dismissed fjoshuajr’s stale review February 9, 2019 00:28

feedback addressed

@cezaraugusto cezaraugusto merged commit 6bb8910 into reactjs:master Feb 9, 2019
@tesseralis tesseralis mentioned this pull request Feb 9, 2019
Closed
90 tasks
@cezaraugusto cezaraugusto added 🌐 translated Translation is completed for this page and removed needs review A pull request ready to be reviewed labels Feb 9, 2019
@fjoshuajr fjoshuajr changed the title Translate babel error message and source code comments Translate CodeEditor Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjoshuajr fjoshuajr fjoshuajr left review comments

@cezaraugusto cezaraugusto cezaraugusto approved these changes

@glaucia86 glaucia86 glaucia86 approved these changes

Assignees
No one assigned
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abnersajr @fjoshuajr @glaucia86 @cezaraugusto