Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add spacing bwtween markdown #1082

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Conversation

datoybi
Copy link
Contributor

@datoybi datoybi commented Oct 14, 2024

안녕하세요!
한국어 문서에서 띄어쓰기가 안되어있는 부분을 발견하여 수정하였습니다.

Progress

Copy link

vercel bot commented Oct 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
ko-legacy-reactjs-org ⬜️ Ignored (Inspect) Visit Preview Oct 15, 2024 3:32am

Copy link

github-actions bot commented Oct 14, 2024

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@lumirlumir
Copy link
Collaborator

lumirlumir commented Oct 14, 2024

안녕하세요, UI는 명사처럼 취급되기 때문에 뒤에 오는 조사는 붙여써야 합니다.

해당 내용은 반영 불가하여 클로즈 하겠습니다.

@lumirlumir lumirlumir closed this Oct 14, 2024
@hg-pyun
Copy link
Member

hg-pyun commented Oct 14, 2024

@lumirlumir
요거 아마 마크다운 강조 표시가 붙어 있으면 적용이 안되서 띄어쓰기를 넣은 것으로 생각됩니다. 아래 diff을 보시면 as-is에는 **가 들어가있어요.

image

@hg-pyun hg-pyun reopened this Oct 14, 2024
@lumirlumir
Copy link
Collaborator

@hg-pyun 아하 그러면 띄어쓰기 말고 마크다운 기호를 다른거로 바꾸는 방향으로 가야될 것 같습니다!

Copy link
Collaborator

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lumirlumir lumirlumir merged commit b4929a0 into reactjs:main Oct 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants