Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate hooks-effect (Using the Effect Hook) #54

Merged
merged 6 commits into from
Feb 7, 2019
Merged

Translate hooks-effect (Using the Effect Hook) #54

merged 6 commits into from
Feb 7, 2019

Conversation

smikitky
Copy link
Member

@smikitky smikitky commented Feb 3, 2019

4th (out of 8) article of the Hooks series

@smikitky smikitky requested a review from potato4d February 3, 2019 07:05
@tesseralis tesseralis mentioned this pull request Feb 3, 2019
Closed
90 tasks
@smikitky
Copy link
Member Author

smikitky commented Feb 3, 2019

@takanorip ありがとうございます、コメントした数カ所にお返事いただけますでしょうか

@koba04 koba04 requested review from koba04 and removed request for koba04 February 4, 2019 01:17
koba04
koba04 requested changes Feb 6, 2019
View reviewed changes
Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smikitky 細かい点をいくつかSuggestしたので確認お願いします 🙇

content/docs/hooks-effect.md Outdated Show resolved Hide resolved
content/docs/hooks-effect.md Outdated Show resolved Hide resolved
content/docs/hooks-effect.md Outdated Show resolved Hide resolved
content/docs/hooks-effect.md Outdated Show resolved Hide resolved
@smikitky
Copy link
Member Author

smikitky commented Feb 6, 2019

@koba04 対応しました！

koba04
koba04 approved these changes Feb 6, 2019
View reviewed changes
Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smikitky 対応ありがとうございました！

@smikitky
Copy link
Member Author

smikitky commented Feb 7, 2019

（force-push してもちゃんと conversations は維持されるんですね…さすが GitHub）

@smikitky
Copy link
Member Author

smikitky commented Feb 7, 2019

@potato4d 一通り対応終わりましたので確認＆マージをお願いできれば

@potato4d
Copy link
Member

potato4d commented Feb 7, 2019

@smikitky
既存のレビュー中身が終わるまで Approve してもなというところだったので、内容は既に見ておりますー！
議論が収束したみたいなので、 Approve とマージしてしまいますね。

@potato4d potato4d merged commit 0e8d93b into master Feb 7, 2019
@smikitky
Copy link
Member Author

smikitky commented Feb 7, 2019

@potato4d @takanorip ありがとうございました！

@potato4d potato4d deleted the tr/hooks-effect branch February 20, 2019 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takanorip takanorip takanorip left review comments

@potato4d potato4d potato4d approved these changes

@koba04 koba04 koba04 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smikitky @potato4d @koba04 @takanorip