Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation of "<option>" page #547

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Translation of "<option>" page #547

merged 3 commits into from
Aug 15, 2023

Conversation

paulus85
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Aug 11, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@tdd tdd self-assigned this Aug 14, 2023
@tdd tdd added Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR scope:required-pages Part of the required translations before we can ship translator:beginner The author of this translation has little to no prior doc translation experience Reviewing Un mainteneur qualifié est en train de composer la revue de code and removed Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR labels Aug 14, 2023
Copy link
Collaborator

@tdd tdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Salut @paulus85 !

Avant toute chose, merci pour tout ce boulot ! C'est super cool de nous filer un coup de main.

Pour l'essentiel ce sont des correctifs de conventions typographiques (insécables devant les deux-points, pas de majuscule après, pas de ponctuation en fin de lien, etc.), ainsi que quelques reformulations, notamment lorsque c'était un peu trop mot-à-mot.

Mais sinon cool ! 👍

Avant de traiter les retours, lis bien TOUT ce message, notamment les consignes d'intégration optimale des retours par lot(s)

Tout est fait sous forme de Suggestions GitHub, il te suffit à chaque suggestion que tu approuves de
cliquer le bouton d'ajout au lot de modifs à committer (pas de commit direct !), et sur la fin de créer le commit groupé. (ce mode de regroupement en un seul commit est à favoriser absolument, mais tu devras aller dans l'onglet Files changed pour y accéder, il n'est pas utilisable dans l’onglet Conversation)

Si certaines appellent discussion, n'hésite pas, tu réponds, on en parle, on avance ensemble 🤝

Quand tout sera bouclé côté code, je ferai une repasse visuelle finale en local avant de fusionner. J'y recalerai si besoin les usual suspects : espaces insécables avant les ponctuations doubles, et apostrophes françaises.

Encore mille mercis, j'ai hâte de voir cette PR finalisée et dans main !

src/content/reference/react-dom/components/option.md Outdated Show resolved Hide resolved
src/content/reference/react-dom/components/option.md Outdated Show resolved Hide resolved
src/content/reference/react-dom/components/option.md Outdated Show resolved Hide resolved
src/content/reference/react-dom/components/option.md Outdated Show resolved Hide resolved
src/content/reference/react-dom/components/option.md Outdated Show resolved Hide resolved
src/content/reference/react-dom/components/option.md Outdated Show resolved Hide resolved
src/content/reference/react-dom/components/option.md Outdated Show resolved Hide resolved
src/content/reference/react-dom/components/option.md Outdated Show resolved Hide resolved
src/content/reference/react-dom/components/option.md Outdated Show resolved Hide resolved
src/content/reference/react-dom/components/option.md Outdated Show resolved Hide resolved
@tdd tdd added Reviewed and removed Reviewing Un mainteneur qualifié est en train de composer la revue de code labels Aug 15, 2023
@paulus85
Copy link
Contributor Author

Merci pour ton retour @tdd !

@tdd tdd merged commit 6a2bad9 into reactjs:main Aug 15, 2023
2 checks passed
@paulus85 paulus85 deleted the feat/option branch August 15, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed scope:required-pages Part of the required translations before we can ship translator:beginner The author of this translation has little to no prior doc translation experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants