Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation of the “React Developer Tools” page #479

Merged
merged 4 commits into from
May 29, 2023

Conversation

Ameliegre
Copy link
Contributor

Voici ma PR pour la page React Developer Tools 😀

@tdd tdd self-requested a review May 26, 2023 17:10
@tdd tdd self-assigned this May 26, 2023
@tdd tdd added Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR scope:required-pages Part of the required translations before we can ship translator:beginner The author of this translation has little to no prior doc translation experience labels May 26, 2023
@tdd tdd added Reviewing Un mainteneur qualifié est en train de composer la revue de code and removed Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR labels May 26, 2023
Copy link
Collaborator

@tdd tdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Salut @Ameliegre !

Avant toute chose, merci pour tout ce boulot ! C'est super cool de nous filer un coup de main.

Bon, on a les petites bévues usuelles des primo-traducteurs. L'essentiel de mes suggestions va dans les catégories suivantes :

  • Aspects typographiques
  • Arbitrage incorrect français / anglais

Rien de bien méchant ! 😉

Avant de traiter les retours, lis bien TOUT ce message, notamment les consignes d'intégration optimale des retours par lot(s)

Tout est fait sous forme de Suggestions GitHub, il te suffit à chaque suggestion que tu approuves de
cliquer le bouton d'ajout au lot de modifs à committer (pas de commit direct !), et sur la fin de créer le commit groupé. (ce mode de regroupement en un seul commit est à favoriser absolument, mais tu devras aller dans l'onglet Files changed pour y accéder, il n'est pas utilisable dans l’onglet Conversation)

Si certaines appellent discussion, n'hésite pas, tu réponds, on en parle, on avance ensemble 🤝

Quand tout sera bouclé côté code, je ferai une repasse visuelle finale en local avant de fusionner. J'y recalerai si besoin les usual suspects : espaces insécables avant les ponctuations doubles, et apostrophes françaises.

Encore mille mercis, j'ai hâte de voir cette PR finalisée et dans main !

src/content/learn/react-developer-tools.md Outdated Show resolved Hide resolved
src/sidebarLearn.json Outdated Show resolved Hide resolved
src/content/learn/react-developer-tools.md Outdated Show resolved Hide resolved
src/content/learn/react-developer-tools.md Outdated Show resolved Hide resolved
src/content/learn/react-developer-tools.md Outdated Show resolved Hide resolved
src/content/learn/react-developer-tools.md Outdated Show resolved Hide resolved
src/content/learn/react-developer-tools.md Outdated Show resolved Hide resolved
src/content/learn/react-developer-tools.md Outdated Show resolved Hide resolved
src/content/learn/react-developer-tools.md Outdated Show resolved Hide resolved
src/content/learn/react-developer-tools.md Outdated Show resolved Hide resolved
@tdd tdd added Reviewed and removed Reviewing Un mainteneur qualifié est en train de composer la revue de code labels May 26, 2023
@Ameliegre
Copy link
Contributor Author

Je viens de commit les modifs, merci pour cette review!
Et oui en relisant la correction, c'est vrai qu'il y des choses qui paraissent logique ! On en apprends tous les jours 😊

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 75.97 KB (🟡 +6 B) 179.12 KB
/500 75.96 KB (🟡 +6 B) 179.12 KB
/[[...markdownPath]] 77.45 KB (🟡 +6 B) 180.6 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@tdd tdd merged commit e27a41c into reactjs:main May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed scope:required-pages Part of the required translations before we can ship translator:beginner The author of this translation has little to no prior doc translation experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants