Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation of the "react: Components" page #465

Merged
merged 4 commits into from
May 6, 2023

Conversation

bastiendmt
Copy link
Contributor

Hello voici ma PR pour la page composants, cette page est assez courte.

@github-actions
Copy link

github-actions bot commented May 1, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@tdd tdd added Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR scope:required-pages Part of the required translations before we can ship translator:beginner The author of this translation has little to no prior doc translation experience labels May 1, 2023
@tdd tdd self-assigned this May 1, 2023
@tdd tdd self-requested a review May 1, 2023 15:51
Copy link
Collaborator

@tdd tdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Salut @bastiendmt !

Avant toute chose, merci pour ce boulot ! C'est super cool de continuer à nous filer un coup de main.

Avant de traiter les retours, lis bien TOUT ce message, notamment les consignes d'intégration optimale des retours par lot(s)

Tout est fait sous forme de Suggestions GitHub, il te suffit à chaque suggestion que tu approuves de
cliquer le bouton d'ajout au lot de modifs à committer (pas de commit direct !), et sur la fin de créer le commit groupé. (ce mode de regroupement en un seul commit est à favoriser absolument, mais tu devras aller dans l'onglet Files changed pour y accéder, il n'est pas utilisable dans l’onglet Conversation)

Si certaines appellent discussion, n'hésite pas, tu réponds, on en parle, on avance ensemble 🤝

Quand tout sera bouclé côté code, je ferai une repasse visuelle finale en local avant de fusionner. J'y recalerai si besoin les usual suspects : espaces insécables avant les ponctuations doubles, et apostrophes françaises.

Encore mille mercis, j'ai hâte de voir cette PR finalisée et dans main !

src/content/reference/react/components.md Outdated Show resolved Hide resolved
src/content/reference/react/components.md Outdated Show resolved Hide resolved
src/content/reference/react/components.md Outdated Show resolved Hide resolved
src/content/reference/react/components.md Outdated Show resolved Hide resolved
src/content/reference/react/components.md Outdated Show resolved Hide resolved
Co-authored-by: Christophe Porteneuve <[email protected]>
@tdd
Copy link
Collaborator

tdd commented May 1, 2023 via email

@bastiendmt bastiendmt requested a review from tdd May 3, 2023 07:53
@tdd tdd added Reviewed and removed Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR labels May 6, 2023
@tdd tdd merged commit eddddda into reactjs:main May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed scope:required-pages Part of the required translations before we can ship translator:beginner The author of this translation has little to no prior doc translation experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants