Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding rendering-lists translation #551

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Adding rendering-lists translation #551

merged 1 commit into from
Oct 10, 2022

Conversation

Oussamaosman02
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 10, 2022

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 88.3 KB (🟢 -302 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 43.09 KB (🟡 +1.04 KB) 131.39 KB
/500 43.07 KB (🟡 +1.04 KB) 131.37 KB
/[[...markdownPath]] 43.16 KB (🟡 +1.03 KB) 131.46 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link
Member

@carburo carburo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hola @Oussamaosman02. Muchas gracias por la contribución. Este PR está casi listo para ser mezclado; solo necesito que apliques algunas correcciones menores y estaríamos listos para continuar.

@Oussamaosman02
Copy link
Contributor Author

Hola @carburo , perdón por esos fallos, revisé bien pero algo se tenía que escapar😜
Le doy a resolve conversation en las que has corrgido mis errores, ¿no?

Copy link
Member

@carburo carburo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No fue posible aplicar los cambios porque el fork con el que originalmente creaste el PR ya no existe. Mezclaré los como está ahora y luego aplico los cambios. ¡Muchas gracias!

@carburo carburo merged commit 82aba7e into reactjs:main Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants