Skip to content

fix: support -/@ symbols in csproj names #1921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisPulman merged 4 commits into from
Nov 8, 2024
Merged

fix: support -/@ symbols in csproj names #1921

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f9db732
fix: support - symbols in csproj names
TimothyMakkison Nov 7, 2024
7d3b00a
fix: revert
TimothyMakkison Nov 7, 2024
744d4df
fix: remove -,@ symbols in namespaces
TimothyMakkison Nov 7, 2024
bd545e3
Merge branch 'main' into unique_name_kebab
ChrisPulman Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions InterfaceStubGenerator.Shared/Parser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ CancellationToken cancellationToken

refitInternalNamespace = $"{refitInternalNamespace ?? string.Empty}RefitInternalGenerated";

// Remove - as they are valid in csproj, but invalid in a namespace
refitInternalNamespace = refitInternalNamespace.Replace('-', '_').Replace('@', '_');

// we're going to create a new compilation that contains the attribute.
// TODO: we should allow source generators to provide source during initialize, so that this step isn't required.
var options = (CSharpParseOptions)compilation.SyntaxTrees[0].Options;
Expand Down