Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extract logic and small cleanups #1755

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

TimothyMakkison
Copy link
Contributor

@TimothyMakkison TimothyMakkison commented Jul 7, 2024

  • Extract logic for parameter mapping to AddObjectParametersToUrl and AddValueParameterToUrl
  • Small formatting fixes

Final bit of #1740 because I can't get #1730 to work 😄

@TimothyMakkison TimothyMakkison marked this pull request as ready for review July 7, 2024 23:00
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 96.15385% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.58%. Comparing base (6ebeda5) to head (c0aabe8).
Report is 59 commits behind head on main.

Files Patch % Lines
Refit/RequestBuilderImplementation.cs 96.15% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1755      +/-   ##
==========================================
- Coverage   87.73%   83.58%   -4.15%     
==========================================
  Files          33       36       +3     
  Lines        2348     2431      +83     
  Branches      294      343      +49     
==========================================
- Hits         2060     2032      -28     
- Misses        208      316     +108     
- Partials       80       83       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisPulman ChrisPulman merged commit 6985161 into reactiveui:main Jul 8, 2024
2 of 3 checks passed
@TimothyMakkison TimothyMakkison deleted the param_refac branch July 8, 2024 20:20
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants