Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document InnerHandler null requirement for DI #1569

Merged
merged 2 commits into from
Oct 1, 2023
Merged

Document InnerHandler null requirement for DI #1569

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa20fce
Document InnerHandler null requirement for DI
bbrandt Sep 27, 2023
93c530f
Merge branch 'main' into patch-1
glennawatson Oct 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,7 +599,9 @@ some interface `ITenantProvider` and has a data store `IAuthTokenStore` that can
{
this.tenantProvider = tenantProvider ?? throw new ArgumentNullException(nameof(tenantProvider));
this.authTokenStore = authTokenStore ?? throw new ArgumentNullException(nameof(authTokenStore));
InnerHandler = new HttpClientHandler();
// InnerHandler must be left as null when using DI, but must be assigned a value when
// using RestService.For<IMyApi>
// InnerHandler = new HttpClientHandler();
}

protected override async Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
Expand Down