Skip to content

Ensure binding list provides RefreshItem when a refresh change is received - #678

Merged
RolandPheasant merged 3 commits into
mainfrom
fix/BindingListReset
Feb 24, 2023
Merged

Ensure binding list provides RefreshItem when a refresh change is received#678
RolandPheasant merged 3 commits into
mainfrom
fix/BindingListReset

Conversation

@RolandPheasant

Copy link
Copy Markdown
Collaborator

This is a WIP

@Metadorius

Metadorius commented Feb 22, 2023

Copy link
Copy Markdown
Contributor

Any further progress on this? Or can I help somehow?

@RolandPheasant

Copy link
Copy Markdown
Collaborator Author

Any further progress on this? Or can I help somehow?

Doh. I forgot to get around to writing unit tests. I'll put a reminder in to do it before the end of the week !

@RolandPheasant
RolandPheasant marked this pull request as ready for review February 23, 2023 09:57
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #678 (37cc537) into main (957135a) will decrease coverage by 0.09%.
The diff coverage is 54.38%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #678      +/-   ##
==========================================
- Coverage   71.99%   71.90%   -0.09%     
==========================================
  Files         216      216              
  Lines       10812    10871      +59     
==========================================
+ Hits         7784     7817      +33     
- Misses       3028     3054      +26     
Impacted Files Coverage Δ
src/DynamicData/Binding/BindingListEx.cs 70.94% <49.01%> (-16.94%) ⬇️
src/DynamicData/Binding/BindingListAdaptor.cs 92.85% <100.00%> (+0.75%) ⬆️
...rc/DynamicData/Binding/SortedBindingListAdaptor.cs 71.05% <100.00%> (+3.40%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@RolandPheasant
RolandPheasant merged commit 260c034 into main Feb 24, 2023
@RolandPheasant
RolandPheasant deleted the fix/BindingListReset branch February 24, 2023 12:53
@github-actions

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants