Remove try/finally from SelectMany in TransformAsync, which was causing race condition for some reason - #664
Merged
RolandPheasant merged 6 commits intoNov 23, 2022
Conversation
added 3 commits
November 17, 2022 13:13
Fixes reactivemarbles#663, where finnaly caused race condition
Contributor
Author
|
This PR might be terrible, or just a workaround, someone smarter might identify the cause of the race condition, but as is seen in the issue #663, the actual issue is wild and someone might understand why that happens better |
RolandPheasant
approved these changes
Nov 23, 2022
RolandPheasant
left a comment
RolandPheasant
left a comment
Collaborator
There was a problem hiding this comment.
Let's hope this fixes it for all time !
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #663