Skip to content

Use replace instead of remove+add on ObservableCollectionAdaptor.DoUpdate - #381

Merged
glennawatson merged 2 commits into
reactivemarbles:mainfrom
wilversings:master
Jul 24, 2020
Merged

Use replace instead of remove+add on ObservableCollectionAdaptor.DoUpdate#381
glennawatson merged 2 commits into
reactivemarbles:mainfrom
wilversings:master

Conversation

@wilversings

@wilversings wilversings commented Jul 6, 2020

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?
Bug fix

What is the current behavior?
#378

What is the new behavior?
ObservableCollectionAdaptor will use the Replace ext method in order to trigger a
NotifyCollectionChangedAction.Replace event action type

What might this PR break?
Uses that rely on this behavior: #378

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • [not needed] Docs have been added / updated (for bug fixes / features)

@dnfadmin

dnfadmin commented Jul 6, 2020

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@RolandPheasant

Copy link
Copy Markdown
Collaborator

The change looks good. It can be merged, but can you sign the contributor license agreement agreement please?

@wilversings

Copy link
Copy Markdown
Contributor Author

Yes, only need to check with my employer first.

@glennawatson
glennawatson merged commit 6912429 into reactivemarbles:main Jul 24, 2020
@wilversings
wilversings deleted the master branch July 24, 2020 04:30
@robsonj

robsonj commented Sep 30, 2020

Copy link
Copy Markdown
Contributor

Hi There,

This change unfortunately breaks our DataGrid (Infragistics)...

Have been tracking down an issue with one of our UI's that is backed with ReactiveUI and DD, its a datagrid that has some some grouping, grouped on a status within the domain object. If the state value of the domain object changes, the item regroups to the appropriate state based group. Works perfectly with DD 6.16.2, but does not work with 6.16.3, I think this relates to this change in behaviour.

I also pulled in this code to our own code base, to verifying that reverting this one change, fixes the issue, which it did.

@github-actions

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants