Use replace instead of remove+add on ObservableCollectionAdaptor.DoUpdate - #381
Conversation
|
The change looks good. It can be merged, but can you sign the contributor license agreement agreement please? |
|
Yes, only need to check with my employer first. |
|
Hi There, This change unfortunately breaks our DataGrid (Infragistics)... Have been tracking down an issue with one of our UI's that is backed with ReactiveUI and DD, its a datagrid that has some some grouping, grouped on a status within the domain object. If the state value of the domain object changes, the item regroups to the appropriate state based group. Works perfectly with DD 6.16.2, but does not work with 6.16.3, I think this relates to this change in behaviour. I also pulled in this code to our own code base, to verifying that reverting this one change, fixes the issue, which it did. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
#378
What is the new behavior?
ObservableCollectionAdaptor will use the Replace ext method in order to trigger a
NotifyCollectionChangedAction.Replace event action type
What might this PR break?
Uses that rely on this behavior: #378
Please check if the PR fulfills these requirements