Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to Node 12.14.1 #6029

Merged
merged 2 commits into from
Jan 16, 2020
Merged

Conversation

aldeed
Copy link
Contributor

@aldeed aldeed commented Jan 14, 2020

Resolves #5770
Impact: minor
Type: feature

Changes

The project now runs on Node 12.14.1 both for development and for future production builds. This is an LTS version.

Breaking changes

This version of Node requires the new --experimental-json-modules flag to run because we import JSON files from many ES modules. This is handled already in the package.json scripts but if you are doing something non-standard, you may need to add this flag yourself.

Testing

In general you should test 3 variations:

Case 1:
docker-compose up -d with the docker-compose.override.yml file should just work

Case 2:

docker-compose down
docker build . -t test-api
docker-compose up -d mongo
docker run --env-file ./.env -p 3000:3000 --network streams.reaction.localhost -it test-api:latest

The docker build command should not have any errors and the API should start in production mode without any errors.

Case 3:
To test docker-compose up -d without the docker-compose.override.yml file, you will need to temporarily change the api.image value in docker-compose.yml to reactioncommerce/reaction:feat-aldeed-node-12.14.1

Signed-off-by: Eric Dobbertin <[email protected]>
@aldeed aldeed self-assigned this Jan 14, 2020
Signed-off-by: Eric Dobbertin <[email protected]>
@aldeed aldeed requested a review from willopez January 15, 2020 23:47
Copy link
Member

@willopez willopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested all scenarios and they all work as intended.

@willopez willopez merged commit 5381db9 into release-3.0.0 Jan 16, 2020
@willopez willopez deleted the feat-aldeed-node-12.14.1 branch January 16, 2020 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants