-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement search React documentation command #348 #349
Conversation
PR Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it's taken me a while to come back to this!! I think this is a solid effort and a valuable addition, in trying to use it I'm finding it awkward — pretty heavily reliant on knowing what terms are available, and the cooldown makes trial-and-error tough. I'm down to merge this though and iterate, merge whenever you're comfortable 👍
(Failing check is expected, non-org contributions fail cuz of a permissions bug that hasn't been worth chasing down yet)
This is maybe a candidate for swapping out to a slash command + autocomplete, I think there's prior art for that in #241 |
Implemented additional commands
!docs
and!react-docs
to search React documentation. The output embed will contain a link to documentation and short intro segment from their page.Extra:
icon_url
not being found.