resolve or remove unneeded unused-promise Flow annotations#55107
Draft
Simek wants to merge 1 commit into
Draft
Conversation
meta-cla
Bot
added
the
CLA Signed
Job Summary for GradleTest All :: run_fantom_tests
|
Simek
force-pushed
the
resolve-unused-promises-annotations
branch
from
325412a to
ac84d9a
Compare
Job Summary for GradleTest All :: run_fantom_tests
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Find all
unused-promiseFlow annotations in core package, look at code and typings, usevoidto allow calling Promises without follow up, or just remove the annotation if the code no longer uses Promise.Changelog:
[INTERNAL] [FIXED] - Resolve or remove unneeded
unused-promiseFlow annotationsTest Plan:
Running
yarn flow-checkdoes not yield any errors.