Catch NullPointerException for `onRequestPermissionsResult` by chakrihacker · Pull Request #39715 · react/react-native

chakrihacker · 2023-09-29T11:15:31Z

Summary:

On Android 13 Devices, we are seeing NullPointerException, which should be handled with this

Changelog:

[ANDROID] [FIXED] - Handle Crash for onRequestPermissionsResult

Test Plan:

On Android 13 Devices, we are seeing `NullPointerException`, which should be handled with this

analysis-bot · 2023-09-29T11:44:01Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	16,902,910	-414,693
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	20,381,655	-304,057
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: bad027c
Branch: main

javache · 2023-09-29T12:41:17Z

Generally catching a NullPointerException means you're masking an underlying error. What object is null?

github-actions · 2023-09-29T12:46:36Z

	Warnings
⚠️	One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against c114c0c

NickGerleman · 2023-10-01T09:00:05Z

Do you have a callstack?

chakrihacker · 2023-10-03T05:25:49Z

Here's the CallStack

Fatal Exception: java.lang.RuntimeException: Unable to resume activity {com.cpt_oe_react_app/com.cpt_oe_react_app.MainActivity}: java.lang.NullPointerException: Attempt to invoke interface method 'void com.facebook.react.bridge.Callback.invoke(java.lang.Object[])' on a null object reference
       at android.app.ActivityThread.performResumeActivity(ActivityThread.java:4945)
       at android.app.ActivityThread.handleResumeActivity(ActivityThread.java:4978)
       at android.app.servertransaction.ResumeActivityItem.execute(ResumeActivityItem.java:54)
       at android.app.servertransaction.ActivityTransactionItem.execute(ActivityTransactionItem.java:45)
       at android.app.servertransaction.TransactionExecutor.executeLifecycleState(TransactionExecutor.java:176)
       at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:97)
       at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2402)
       at android.os.Handler.dispatchMessage(Handler.java:106)
       at android.os.Looper.loopOnce(Looper.java:210)
       at android.os.Looper.loop(Looper.java:299)
       at android.app.ActivityThread.main(ActivityThread.java:8136)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:580)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1028)

Caused by java.lang.NullPointerException: Attempt to invoke interface method 'void com.facebook.react.bridge.Callback.invoke(java.lang.Object[])' on a null object reference
       at com.facebook.react.modules.permissions.PermissionsModule.onRequestPermissionsResult(PermissionsModule.java:201)
       at com.facebook.react.ReactActivityDelegate$2.invoke(ReactActivityDelegate.java:201)
       at com.facebook.react.ReactActivityDelegate.onResume(ReactActivityDelegate.java:126)
       at com.facebook.react.ReactActivity.onResume(ReactActivity.java:58)
       at com.cpt_oe_react_app.MainActivity.onResume(MainActivity.kt:70)
       at android.app.Instrumentation.callActivityOnResume(Instrumentation.java:1564)
       at android.app.Activity.performResume(Activity.java:8674)
       at android.app.ActivityThread.performResumeActivity(ActivityThread.java:4934)
       at android.app.ActivityThread.handleResumeActivity(ActivityThread.java:4978)
       at android.app.servertransaction.ResumeActivityItem.execute(ResumeActivityItem.java:54)
       at android.app.servertransaction.ActivityTransactionItem.execute(ActivityTransactionItem.java:45)
       at android.app.servertransaction.TransactionExecutor.executeLifecycleState(TransactionExecutor.java:176)
       at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:97)
       at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2402)
       at android.os.Handler.dispatchMessage(Handler.java:106)
       at android.os.Looper.loopOnce(Looper.java:210)
       at android.os.Looper.loop(Looper.java:299)
       at android.app.ActivityThread.main(ActivityThread.java:8136)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:580)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1028)

I am on react native 0.72.4

chakrihacker · 2023-10-03T13:39:03Z

grantResults, getPermissionAwareActivity() one of the argument is null

javache · 2023-10-05T12:43:26Z

      mCallbacks.get(requestCode).invoke(grantResults, getPermissionAwareActivity());
      mCallbacks.remove(requestCode);


Instead add a null-check here.

Suggested change

mCallbacks.get(requestCode).invoke(grantResults, getPermissionAwareActivity());

mCallbacks.remove(requestCode);

Callback callback = mCallbacks.get(requestCode);

if (callback != null) {

callback.invoke(grantResults, getPermissionAwareActivity());

mCallbacks.remove(requestCode);

} else {

// Log warning. It's unexpected we're getting a response here we didn't ask for.

}

javache · 2023-10-05T15:47:10Z

+        String message = "Unable to find callback with requestCode:" + requestCode;
+        FLog.w("PermissionsModule", message);


nit: inline message

Suggested change

String message = "Unable to find callback with requestCode:" + requestCode;

FLog.w("PermissionsModule", message);

FLog.w("PermissionsModule", "Unable to find callback with requestCode:" + requestCode);

Actually, since this is FLog, you can do FLog.w("PermissionsModule", "Unable to find callback with requestCode %d", requestCode).

Thank you updated

facebook-github-bot · 2023-10-05T19:23:58Z

@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2023-10-06T11:23:49Z

@javache merged this pull request in 9252099.

Catch NullPointerException for onRequestPermissionsResult

72678c5

On Android 13 Devices, we are seeing `NullPointerException`, which should be handled with this

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Sep 29, 2023

javache requested changes Oct 5, 2023

View reviewed changes

fix(android): add null check for callback

66250cb

javache reviewed Oct 5, 2023

View reviewed changes

remove extra variable allocation for message

c114c0c

facebook-github-bot closed this in 9252099 Oct 6, 2023

facebook-github-bot added the Merged This PR has been merged. label Oct 6, 2023

gewfy mentioned this pull request Jul 20, 2024

Crash when trying to join a session 29ki/29k#5630

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Catch NullPointerException for `onRequestPermissionsResult`#39715

Catch NullPointerException for `onRequestPermissionsResult`#39715
chakrihacker wants to merge 3 commits into
react:mainfrom
chakrihacker:fix/add-null-pointer-exception-handling

chakrihacker commented Sep 29, 2023 •

edited

Loading

Uh oh!

analysis-bot commented Sep 29, 2023 •

edited

Loading

Uh oh!

javache commented Sep 29, 2023

Uh oh!

github-actions Bot commented Sep 29, 2023 •

edited

Loading

Uh oh!

NickGerleman commented Oct 1, 2023

Uh oh!

chakrihacker commented Oct 3, 2023

Uh oh!

chakrihacker commented Oct 3, 2023

Uh oh!

javache Oct 5, 2023

Uh oh!

javache Oct 5, 2023

Uh oh!

javache Oct 5, 2023

Uh oh!

chakrihacker Oct 5, 2023

Uh oh!

facebook-github-bot commented Oct 5, 2023

Uh oh!

facebook-github-bot commented Oct 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		mCallbacks.get(requestCode).invoke(grantResults, getPermissionAwareActivity());
		mCallbacks.remove(requestCode);

-      mCallbacks.get(requestCode).invoke(grantResults, getPermissionAwareActivity());
-      mCallbacks.remove(requestCode);
+      Callback callback = mCallbacks.get(requestCode);
+      if (callback != null) {
+         callback.invoke(grantResults, getPermissionAwareActivity());
+         mCallbacks.remove(requestCode);
+      } else {
+         // Log warning. It's unexpected we're getting a response here we didn't ask for.
+      }

		String message = "Unable to find callback with requestCode:" + requestCode;
		FLog.w("PermissionsModule", message);

	String message = "Unable to find callback with requestCode:" + requestCode;
	FLog.w("PermissionsModule", message);
	FLog.w("PermissionsModule", "Unable to find callback with requestCode:" + requestCode);

Uh oh!

Conversation

chakrihacker commented Sep 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary:

Changelog:

Test Plan:

Uh oh!

analysis-bot commented Sep 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

javache commented Sep 29, 2023

Uh oh!

github-actions Bot commented Sep 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NickGerleman commented Oct 1, 2023

Uh oh!

chakrihacker commented Oct 3, 2023

Uh oh!

chakrihacker commented Oct 3, 2023

Uh oh!

javache Oct 5, 2023

Choose a reason for hiding this comment

Uh oh!

javache Oct 5, 2023

Choose a reason for hiding this comment

Uh oh!

javache Oct 5, 2023

Choose a reason for hiding this comment

Uh oh!

chakrihacker Oct 5, 2023

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Oct 5, 2023

Uh oh!

facebook-github-bot commented Oct 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

chakrihacker commented Sep 29, 2023 •

edited

Loading

analysis-bot commented Sep 29, 2023 •

edited

Loading

github-actions Bot commented Sep 29, 2023 •

edited

Loading