Skip to content

chore(LinkingExample): Update external URLs description #33023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gabrieldonadel wants to merge 2 commits into from
Closed

chore(LinkingExample): Update external URLs description #33023

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
897e34f
chore(linkingexample): Update external URLs description
gabrieldonadel Feb 2, 2022
3297b87
chore(linkingexample): Fix typo
gabrieldonadel Feb 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/rn-tester/js/examples/Linking/LinkingExample.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,13 @@ class OpenURLButton extends React.Component<Props> {
if (supported) {
Linking.openURL(this.props.url);
} else {
console.log("Don't know how to open URI: " + this.props.url);
console.log(
`Don't know how to open URI: ${
this.props.url
}, ensure you have an app installed that handles the "${
this.props.url.split(':')?.[0]
}" scheme`,
);
}
});
};
Expand Down Expand Up @@ -134,6 +140,8 @@ exports.description = 'Shows how to use Linking to open URLs.';
exports.examples = [
{
title: 'Open external URLs',
description:
'Custom schemes may require specific apps to be installed oo the device. Note: Phone app is not supported in the simulator.',

@dmytrorykun dmytrorykun Feb 2, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'Custom schemes may require specific apps to be installed oo the device. Note: Phone app is not supported in the simulator.',
'Custom schemes may require specific apps to be installed on the device. Note: Phone app is not supported in the simulator.',

@gabrieldonadel gabrieldonadel Feb 2, 2022

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, my bad, I've just fixed it

render: function (): React.Element<typeof IntentAndroidExample> {
return <IntentAndroidExample />;
},
Expand Down