Remove 'qs' dependency, update yarn lock#30125
Closed
Simek wants to merge 1 commit into
Closed
Conversation
Base commit: 8e943d8 |
Base commit: 8e943d8 |
Simek
force-pushed
the
chore-remove-unused-qs
branch
from
October 7, 2020 22:46
0dbcac3 to
51872a0
Compare
Simek
force-pushed
the
chore-remove-unused-qs
branch
from
October 7, 2020 22:51
51872a0 to
8401b4c
Compare
facebook-github-bot
left a comment
Contributor
There was a problem hiding this comment.
@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
This pull request was successfully merged by @Simek in 38bc5df. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes unused
qspackage (query string parser) from the mainpackage.jsonfile.I was not able to find any explicit usage of this package in the repository. Looking at the commit which introduced this package it is not clear why it has been added, query string is not processed in any way.
I have also run
yarn update-lockto clean up lock after latest dependencies bumps. There are noqspackage entry removal in yarn lock, because it is already required byrequestpackage.Refs: b4785e5
Changelog
[Internal] [Removed] - remove unused
qsdependencyTest Plan
This change should not affect the code base.