Skip to content

Backwards compatibility in findMatchingSimulator version input #23305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
osunnarvik wants to merge 2 commits into from
Closed

Backwards compatibility in findMatchingSimulator version input #23305

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74e22ca
handling dot-version input in findMatchingSimulator also when using n…
osunnarvik Feb 6, 2019
1c39f66
added missing semicolon
osunnarvik Feb 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion local-cli/runIOS/findMatchingSimulator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ function findMatchingSimulator(simulators, simulatorString) {
if (!version.includes('iOS') && !version.includes('tvOS')) {
continue;
}
if (simulatorVersion && !version.endsWith(simulatorVersion)) {
let versionWithDashReplacedByDot = version.replace(/-/g,'\.')

@analysis-bot analysis-bot Feb 6, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier/prettier: Replace '\.') with ·'.');

@analysis-bot analysis-bot Feb 6, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

semi: Missing semicolon.

if (simulatorVersion && !versionWithDashReplacedByDot.endsWith(simulatorVersion)) {

@analysis-bot analysis-bot Feb 6, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier/prettier: Replace simulatorVersion·&&·!versionWithDashReplacedByDot.endsWith(simulatorVersion) with ⏎······simulatorVersion·&&⏎······!versionWithDashReplacedByDot.endsWith(simulatorVersion)⏎····

continue;
}
for (let i in devices[version]) {
Expand Down