Skip to content

Catch attempts to import * as x from react-native #16992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
robhogan wants to merge 4 commits into from
Closed

Catch attempts to import * as x from react-native #16992

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fb417bb
Catch attempts to import * as x from react-native
rh389 Nov 28, 2017
ffd6029
Typo
rh389 Nov 28, 2017
1676b78
Merge branch 'master' into patch-15
rh389 Nov 29, 2017
205420f
Merge branch 'master' into patch-15
rh389 Jan 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Libraries/react-native/react-native-implementation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,15 @@ const invariant = require('fbjs/lib/invariant');

// Export React, plus some native additions.
const ReactNative = {
// Dummy export, to catch attempts to import *
get _() {
invariant(
false,
'Importing all exports from react-native (eg `import * as Foo from "react-native"` is not ' +
'supported. Please be explicit instead (eg `import { Bar } from "react-native"`)'
);
},

// Components
get AccessibilityInfo() { return require('AccessibilityInfo'); },
get ActivityIndicator() { return require('ActivityIndicator'); },
Expand Down