Skip to content

Fix Bug: Set a React Controller whose view is a RCTRootView as a part… #16893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fishmwei wants to merge 4 commits into from
Closed

Fix Bug: Set a React Controller whose view is a RCTRootView as a part… #16893

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
49341f4
Fix Bug: Set a React Controller whose view is a RCTRootView as a part…
Nov 20, 2017
aadc6a1
Merge remote-tracking branch 'upstream/master'
Feb 9, 2018
018d250
Merge remote-tracking branch 'upstream/master'
Feb 24, 2018
37332c5
Merge remote-tracking branch 'upstream/master'
Feb 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions React/Base/RCTRootContentView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,14 @@ - (void)updateAvailableSize
return;
}

//unnecessary to update avaliableSize, it's triggered by setBounds: from RCTUIManager
if (self.superview) {
CGRect superviewFrame = self.superview.bounds;
if (!CGRectEqualToRect(superviewFrame, self.frame)) {

@shergin shergin Nov 21, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, but what is an idea/reasoning behind this changeset?
Comparing view.frame with superview.bounds makes no any sense, I am afraid.

@fishmwei fishmwei Nov 22, 2017 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shergin
I always think that the size of content view should be equal to its super view's size. That's why you set content's frame in the function layoutSubviews of rootView ?

- (void)layoutSubviews
{
  [super layoutSubviews];
  _contentView.frame = self.bounds;  // here
  _loadingView.center = (CGPoint){
    CGRectGetMidX(self.bounds),
    CGRectGetMidY(self.bounds)
  };
}

if view.frame != superview.bounds, it's invalidate. If update avaliableSize in the case, it will lead to set view.bounds with a size which does not equal to superview.bounds later, so the bug occurs.

@fishmwei fishmwei Nov 28, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shergin what's your opinion?

return;
}
}

[_bridge.uiManager setAvailableSize:self.availableSize forRootView:self];
}

Expand Down