Skip to content

Flow type: saveToCameraRoll returns a string #15631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maartenschumacher wants to merge 3 commits into from
Closed

Flow type: saveToCameraRoll returns a string #15631

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d1eba3
Flow type: saveToCameraRoll returns a string
maartenschumacher Aug 24, 2017
cf2861a
Fix flow error
maartenschumacher Aug 24, 2017
a1694e5
Merge branch 'master' into patch-3
shergin Aug 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Libraries/CameraRoll/CameraRoll.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ class CameraRoll {
static saveToCameraRoll(
tag: string,
type?: 'photo' | 'video',
): Promise<Object> {
): Promise<string> {

@eslint-bot eslint-bot Aug 24, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

string This type is incompatible with object type

invariant(
typeof tag === 'string',
'CameraRoll.saveToCameraRoll must be a valid string.',
Expand Down