Add Settings Module Support for the Android Platform

Libraries/Settings/Settings.ios.js → Libraries/Settings/Settings.js

@@ -11,25 +11,44 @@
  */
 'use strict';
 
-var RCTDeviceEventEmitter = require('RCTDeviceEventEmitter');
-var RCTSettingsManager = require('NativeModules').SettingsManager;
+const RCTDeviceEventEmitter = require('RCTDeviceEventEmitter');
+const RCTSettingsManager = require('NativeModules').SettingsManager;
 
-var invariant = require('fbjs/lib/invariant');
+const invariant = require('fbjs/lib/invariant');
 
-var subscriptions: Array<{keys: Array<string>, callback: ?Function}> = [];
+const subscriptions: Array<{keys: Array<string>; callback: ?Function}> = [];
 
-var Settings = {
+/**
+ * @class
+ * @description
+ * An interface to the native "preferences" file storage that uses simple key-value pairs
+ * 
+ */
+const Settings = {
   _settings: RCTSettingsManager && RCTSettingsManager.settings,
 
   get(key: string): mixed {
     return this._settings[key];
   },
 
-  set(settings: Object) {
+ /**
+   * Sets the value for a name-value pairs
+   * @param settings the object with the name/value pairs to set
+   *
+   * Note that on android the only allowed value types are number, string and boolean
+   */
+  set(settings: Object): void {
     this._settings = Object.assign(this._settings, settings);
     RCTSettingsManager.setValues(settings);
   },
 
+
+ /**
+   * Monitor one or more keys for changed values
+   * @param keys a string or an array of strings naming the keys to monitor
+   * @callback the callback to invoke when one of the specified keys updates its value
+   * @returns a number representing the watch ID which can be used to clear the watch
+   */
   watchKeys(keys: string | Array<string>, callback: Function): number {
     if (typeof keys === 'string') {
       keys = [keys];
@@ -40,11 +59,15 @@ var Settings = {
       'keys should be a string or array of strings'
     );
 
-    var sid = subscriptions.length;
+    const sid = subscriptions.length;
     subscriptions.push({keys: keys, callback: callback});
     return sid;
   },
 
+  /**
+   * 
+   * @param {*} watchId a number identifying which set of monitoried keys is to be cleared
+   */
   clearWatch(watchId: number) {
     if (watchId < subscriptions.length) {
       subscriptions[watchId] = {keys: [], callback: null};
@@ -53,8 +76,8 @@ var Settings = {
 
   _sendObservations(body: Object) {
     Object.keys(body).forEach((key) => {
-      var newValue = body[key];
-      var didChange = this._settings[key] !== newValue;
+      const newValue = body[key];
+      const didChange = this._settings[key] !== newValue;
       this._settings[key] = newValue;
 
       if (didChange) {

Libraries/Settings/__tests__/Settings-test.js

@@ -0,0 +1,46 @@
+/**
+ * Copyright (c) 2015-present, Facebook, Inc.
+ * All rights reserved.
+ *
+ * This source code is licensed under the BSD-style license found in the
+ * LICENSE file in the root directory of this source tree. An additional grant
+ * of patent rights can be found in the PATENTS file in the same directory.
+ */
+'use strict';
+
+jest.unmock('../Settings');
+jest.unmock('Platform');
+
+jest.unmock('BatchedBridge');
+jest.unmock('defineLazyObjectProperty');
+jest.unmock('MessageQueue');
+jest.unmock('NativeModules');
+
+let Platform = require('Platform');
+
+const Settings  = require('Settings');
+
+describe('Settings', () => {
+
+  describe('setting and getting', () => {
+    it('should set values and retrieve them', () => {
+
+      if (Platform.OS == 'ios') {
+        expect(true).toEqual(true);
+        return;
+      }
+
+      Settings.set({oneKey: 1});
+      Settings.set({twoKey: 2.0});
+      Settings.set({threeKey: 'three'});
+
+      const oneValue = Settings.get('oneKey');
+      const twoValue = Settings.get('twoKey');
+      const threeValue = Settings.get('threeKey');
+
+      expect(oneValue === 1).toEqual(true);
+      expect(twoValue === 2.0).toEqual(true);
+      expect(threeValue === 'three').toEqual(true);
+    });
+  });
+});

ReactAndroid/src/main/java/com/facebook/react/modules/settings/BUCK

@@ -0,0 +1,18 @@
+include_defs("//ReactAndroid/DEFS")
+
+android_library(
+    name = "settings",
+    srcs = glob(["**/*.java"]),
+    visibility = [
+        "PUBLIC",
+    ],
+    deps = [
+        react_native_dep("third-party/java/infer-annotations:infer-annotations"),
+        react_native_dep("third-party/java/jsr-305:jsr-305"),
+        react_native_target("java/com/facebook/react/bridge:bridge"),
+        react_native_target("java/com/facebook/react/common:common"),
+        react_native_target("java/com/facebook/react/module/annotations:annotations"),
+        react_native_target("java/com/facebook/react/modules/core:core"),
+    ],
+)
+

ReactAndroid/src/main/java/com/facebook/react/modules/settings/SettingsModule.java

@@ -0,0 +1,167 @@
+/*
+ * Copyright (c) 2015-present, Facebook, Inc.
+ * All rights reserved.
+ *
+ * This source code is licensed under the BSD-style license found in the
+ * LICENSE file in the root directory of this source tree. An additional grant
+ * of patent rights can be found in the PATENTS file in the same directory.
+ */
+
+package com.facebook.react.modules.settings;
+
+import android.content.Context;
+import android.content.SharedPreferences;
+
+import com.facebook.react.bridge.Arguments;
+import com.facebook.react.bridge.ReactApplicationContext;
+import com.facebook.react.bridge.ReactContextBaseJavaModule;
+import com.facebook.react.bridge.ReactMethod;
+import com.facebook.react.bridge.ReadableMap;
+import com.facebook.react.bridge.ReadableNativeMap;
+import com.facebook.react.bridge.WritableMap;
+import com.facebook.react.module.annotations.ReactModule;
+import com.facebook.react.modules.core.DeviceEventManagerModule;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Map;
+
+@ReactModule(name = SettingsModule.NAME)
+public class SettingsModule extends ReactContextBaseJavaModule  implements SharedPreferences.OnSharedPreferenceChangeListener{
+
+  @SuppressWarnings("WeakerAccess")
+  static final String NAME = "SettingsManager";
+  static final String DEFAULT_FILE_NAME = "ReactNative";
+
+  static private String sFilename = "";
+  private Boolean ignoringUpdates = false;
+  private SharedPreferences mPreferences;
+
+  public SettingsModule(ReactApplicationContext context) {
+    super(context);
+  }
+
+  @Override
+  public String getName() {
+    return SettingsModule.NAME;
+  }
+
+  private SharedPreferences getPreferences() {
+    if (mPreferences == null) {
+      if (SettingsModule.sFilename.length() > 0) {
+        mPreferences = getReactApplicationContext().getSharedPreferences(SettingsModule.sFilename, Context.MODE_PRIVATE);
+      } else if (getCurrentActivity() != null) {
+        mPreferences = getCurrentActivity().getPreferences(Context.MODE_PRIVATE);
+      } else {
+        mPreferences = getReactApplicationContext().getSharedPreferences(DEFAULT_FILE_NAME, Context.MODE_PRIVATE);
+      }
+      mPreferences.registerOnSharedPreferenceChangeListener(this);
+    }
+
+    return mPreferences;
+  }
+
+  static public void setFilename(String filename) {
+    sFilename = filename;
+  }
+
+  @Override
+  public void onCatalystInstanceDestroy() {
+    getPreferences().unregisterOnSharedPreferenceChangeListener(this);
+  }
+
+  @ReactMethod
+  public void setValues(ReadableMap map) {
+    ReadableNativeMap nativeMap = (ReadableNativeMap) map;
+
+    this.ignoringUpdates = true;
+    this.setValuesToPreference(nativeMap.toHashMap(), getPreferences());
+    this.ignoringUpdates = false;
+  }
+
+  @SuppressWarnings("unchecked")
+  public Map<String, Object> getConstants() {
+    Map<String, Object> map;
+
+    try {
+      map = (Map<String, Object>) getPreferences().getAll();
+
+      for (String key : map.keySet()) {
+        Object value = map.get(key);
+        if (value instanceof HashSet) {
+          ArrayList<Object> list = new ArrayList<>((HashSet<Object>) value);
+          map.put(key, list);
+        }
+
+      }
+    } catch (ClassCastException ex) {
+      map = new HashMap<>();
+    }
+
+    HashMap<String, Object> constants = new HashMap<>();
+
+    constants.put("settings", map);
+    return constants;
+  }
+
+  @Override
+  public void onSharedPreferenceChanged(SharedPreferences sharedPreferences, String prefKey) {
+    if (ignoringUpdates) {
+      return;
+    }
+    Map<String, ?> prefsMap = getPreferences().getAll();
+
+    WritableMap map = Arguments.createMap();
+
+    for (String key: prefsMap.keySet()) {
+      Object value = prefsMap.get(key);
+
+      if (value == null) {
+        map.putNull(key);
+      } else if (value instanceof String) {
+        map.putString(key, (String) value);
+      } else if (value instanceof Number) {
+        if (value instanceof Integer) {
+          map.putInt(key, (Integer) value);
+        } else {
+          map.putDouble(key, ((Number) value).doubleValue());
+        }
+      } else if (value instanceof Boolean) {
+        map.putBoolean(key, (Boolean) value);
+      } else {
+          throw new IllegalArgumentException("Could not convert " + value.getClass());
+      }
+    }
+    if (getReactApplicationContext().hasActiveCatalystInstance()) {
+      getReactApplicationContext().getJSModule(DeviceEventManagerModule.RCTDeviceEventEmitter.class)
+        .emit("settingsUpdated", map);
+    }
+  }
+
+  private void setValuesToPreference(HashMap<String, Object> sourceMap, SharedPreferences pref) {
+    SharedPreferences.Editor editor = pref.edit();
+
+    for (HashMap.Entry<String, Object> entry : sourceMap.entrySet()) {
+      String key = entry.getKey();
+      Object value = entry.getValue();
+
+      if (value != null && !value.getClass().isPrimitive() && !(value instanceof String)) {
+        continue;
+      }
+
+      if (value == null) {
+        editor.remove(key);
+      } else if (value instanceof String) {
+        editor.putString(key, (String) sourceMap.get(key));
+      } else if (value instanceof Number) {
+        Float valueF = ((Number) value).floatValue();
+        editor.putFloat(key, valueF);
+      } if (value instanceof Boolean) {
+        editor.putBoolean(key, (Boolean) sourceMap.get(key));
+      }
+
+    }
+    editor.apply();
+  }
+}

ReactAndroid/src/main/java/com/facebook/react/shell/BUCK

@@ -36,6 +36,7 @@ android_library(
         react_native_target("java/com/facebook/react/modules/network:network"),
         react_native_target("java/com/facebook/react/modules/permissions:permissions"),
         react_native_target("java/com/facebook/react/modules/share:share"),
+        react_native_target("java/com/facebook/react/modules/settings:settings"),
         react_native_target("java/com/facebook/react/modules/statusbar:statusbar"),
         react_native_target("java/com/facebook/react/modules/storage:storage"),
         react_native_target("java/com/facebook/react/modules/timepicker:timepicker"),

ReactAndroid/src/main/java/com/facebook/react/shell/MainReactPackage.java

@@ -52,6 +52,7 @@
 import com.facebook.react.modules.netinfo.NetInfoModule;
 import com.facebook.react.modules.network.NetworkingModule;
 import com.facebook.react.modules.permissions.PermissionsModule;
+import com.facebook.react.modules.settings.SettingsModule;
 import com.facebook.react.modules.share.ShareModule;
 import com.facebook.react.modules.statusbar.StatusBarModule;
 import com.facebook.react.modules.storage.AsyncStorageModule;
@@ -211,6 +212,12 @@ public NativeModule get() {
           return new PermissionsModule(context);
         }
       }),
+      new ModuleSpec(SettingsModule.class, new Provider<NativeModule>() {
+        @Override
+        public NativeModule get() {
+          return new SettingsModule(context);
+        }
+      }),
       new ModuleSpec(ShareModule.class, new Provider<NativeModule>() {
         @Override
         public NativeModule get() {