Add Show / Hide button for the built-in inspector#12824
Closed
jhen0409 wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
GH Review: review-needed
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when we use
react-devtoolsor react inspector of Nuclide for RN, it will hide the built-in inspector contents.The built-in inspector have some features different from
react-devtools, like computed styles, this PR make the two can be used together.Test plan (required)
Manual testing:
Show/Hidefor toggle the inspector contentsScreenshot: