Skip to content

fix exception when ES6 class with no propTypes defined before calling requireNativeComponent #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kejinlu wants to merge 4 commits into from
Closed

fix exception when ES6 class with no propTypes defined before calling requireNativeComponent #1260

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ebb8c67
fix exception when ES6 class with no propTypes defined before calling…
kejinlu May 13, 2015
ee6ac64
fix code style #1260
kejinlu May 14, 2015
62fcfec
Throw a helpful error message when component.propTypes is not defined…
kejinlu May 14, 2015
2618434
Check the name and displayName of component #1260
kejinlu May 16, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Libraries/ReactIOS/verifyPropTypes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ function verifyPropTypes(
}
var nativeProps = viewConfig.nativeProps;
for (var prop in nativeProps) {
if (!component.propTypes[prop] &&
if (component.propTypes != undefined &&

@sahrens sahrens May 13, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use === or !== instead of their looser counterparts whenever possible.

@sahrens sahrens May 13, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or just check truthiness without comparing to undefined.

!component.propTypes[prop] &&
!View.propTypes[prop] &&
!ReactIOSStyleAttributes[prop] &&
(!nativePropsToIgnore || !nativePropsToIgnore[prop])) {
Expand Down