Skip to content

Suggest yarn build over yarn run build #1800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaearon merged 3 commits into from
Mar 12, 2017
Merged

Suggest yarn build over yarn run build #1800

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
060c1c6
Fix for issue #1798: Suggested 'yarn build' versus 'yarn run build'
geoffdavis92 Mar 12, 2017
9d080d3
remove 'run' from 'yarn test' command as well
geoffdavis92 Mar 12, 2017
afbad4e
conditionally show 'run' if Yarn is not available
geoffdavis92 Mar 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/react-scripts/scripts/init.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,13 +149,13 @@ module.exports = function(
console.log(chalk.cyan(` ${displayedCommand} start`));
console.log(' Starts the development server.');
console.log();
console.log(chalk.cyan(` ${displayedCommand} run build`));
console.log(chalk.cyan(` ${displayedCommand} build`));

@gaearon gaearon Mar 12, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work with npm though. We need to check for Yarn specifically.

@geoffdavis92 geoffdavis92 Mar 12, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I updated and pushed a fix for that.

console.log(' Bundles the app into static files for production.');
console.log();
console.log(chalk.cyan(` ${displayedCommand} test`));
console.log(' Starts the test runner.');
console.log();
console.log(chalk.cyan(` ${displayedCommand} run eject`));
console.log(chalk.cyan(` ${displayedCommand} eject`));
console.log(
' Removes this tool and copies build dependencies, configuration files'
);
Expand Down