Skip to content
This repository has been archived by the owner on Jan 30, 2021. It is now read-only.

⬆️ (react-native) calling getNode on the ref is no longer necessary #110

Merged
merged 4 commits into from
Apr 18, 2020

Conversation

ArrayZoneYour
Copy link
Contributor

@ArrayZoneYour ArrayZoneYour commented Mar 31, 2020

Summary

  1. Calling getNode() on the ref of an Animated component is no longer necessary after react-native 0.62. (Calling 'getNode()' on the ref of Animated component is no longer necessary #111)

  2. improve AnimatedView's type

  3. remove example folder from build artifacts(Remove example folder from npm  #106)

Test Plan

yarn prepare worked

console warning disappear

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS
Android

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

@ajiehatajie
Copy link

same issue rn 0.62

@orzhtml
Copy link

orzhtml commented Apr 2, 2020

什么时候能合并代码

@VDetish
Copy link

VDetish commented Apr 2, 2020

Да, мы тоже ждём.

@kulazhenkoa-digicode
Copy link

rn0.62 - waiting for fix

@brentvatne
Copy link
Member

this should be made backwards compatible, so it will work in both 0.62 apps and older apps

Copy link
Member

@brentvatne brentvatne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be backwards compatible

@brentvatne brentvatne merged commit 8e5796d into react-navigation:master Apr 18, 2020
@brentvatne
Copy link
Member

this is released in [email protected]! thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants