refactor: rewrite drawer layout with reanimated (#60)

react-navigation · Aug 18, 2019 · 4bdd06a · 4bdd06a
1 parent e47dcdb
commit 4bdd06a
Show file tree

Hide file tree

Showing 5 changed files with 678 additions and 157 deletions.
diff --git a/packages/drawer/src/index.tsx b/packages/drawer/src/index.tsx
@@ -1,15 +1,15 @@
+import * as DrawerAcions from './routers/DrawerActions';
+
 /**
  * Navigators
  */
-/**
- * Router
- */
-import * as DrawerAcions from './routers/DrawerActions';
-
 export {
   default as createDrawerNavigator,
 } from './navigators/createDrawerNavigator';
 
+/**
+ * Router
+ */
 export { DrawerAcions };
 export { default as DrawerRouter } from './routers/DrawerRouter';
 

diff --git a/packages/drawer/src/navigators/createDrawerNavigator.tsx b/packages/drawer/src/navigators/createDrawerNavigator.tsx
@@ -1,5 +1,5 @@
 import * as React from 'react';
-import { Dimensions, Platform, ScrollView } from 'react-native';
+import { Dimensions, Platform, ScrollView, I18nManager } from 'react-native';
 import { createNavigator } from '@react-navigation/core';
 import { SafeAreaView } from '@react-navigation/native';
 import DrawerRouter from '../routers/DrawerRouter';
@@ -35,14 +35,12 @@ const DefaultDrawerConfig = {
     return Math.min(smallerAxisSize - appBarHeight, maxWidth);
   },
   contentComponent: defaultContentComponent,
-  drawerPosition: 'left',
+  drawerPosition: I18nManager.isRTL ? 'right' : 'left',
   keyboardDismissMode: 'on-drag',
   drawerBackgroundColor: 'white',
-  useNativeAnimations: true,
   drawerType: 'front',
   hideStatusBar: false,
   statusBarAnimation: 'slide',
-  overlayColor: 'black',
 };
 
 const DrawerNavigator = (routeConfigs: object, config: any = {}) => {

diff --git a/packages/drawer/src/types.tsx b/packages/drawer/src/types.tsx
@@ -17,10 +17,6 @@ export type Navigation = {
     key: string;
     index: number;
     routes: Route[];
-    openId: string;
-    closeId: string;
-    toggleId: string;
-    isDrawerIdle: boolean;
     isDrawerOpen: boolean;
   };
   openDrawer: () => void;