Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix completion handler constants #172

Merged
merged 1 commit into from
Oct 17, 2020
Merged

fix completion handler constants #172

merged 1 commit into from
Oct 17, 2020

Conversation

vonovak
Copy link
Contributor

@vonovak vonovak commented Aug 17, 2020 •
edited
Loading

Summary

the constants used in the readme are those for requesting permissions from user, not for displaying a notification

@chrisbobbe
Copy link

Looks right to me; the doc for that looks like it's https://developer.apple.com/documentation/usernotifications/unnotificationpresentationoptions?language=objc.

@vonovak
Copy link
Contributor Author

vonovak commented Oct 14, 2020

@Naturalclar would you please review this? Thank you!

Naturalclar
Naturalclar approved these changes Oct 17, 2020
View reviewed changes
Copy link
Collaborator

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vonovak thank you for catching this!

@Naturalclar Naturalclar merged commit 01d1c84 into master Oct 17, 2020
@Naturalclar Naturalclar deleted the vonovak-fix-completion-handler branch October 17, 2020 01:16
@Naturalclar Naturalclar mentioned this pull request Oct 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naturalclar Naturalclar Naturalclar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vonovak @chrisbobbe @Naturalclar