Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename RNPushNotificationIOS.podspec to RNCPushNotificationIOS.podspec #15

Merged
merged 1 commit into from
Jul 24, 2019

Conversation

Gp2mv3
Copy link
Contributor

@Gp2mv3 Gp2mv3 commented Jul 16, 2019

Avoid autolinking error with RN 60.

Fixes #11

Summary

I had the error when linking the package in our project.

Test Plan

Compiles and executes fine.

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS
Android

Checklist

  • I have tested this on a device

@seeya
Copy link

seeya commented Jul 24, 2019

Please merge this!

@thymikee thymikee merged commit dcef241 into react-native-push-notification:master Jul 24, 2019
@thymikee
Copy link
Contributor

Thank you @Gp2mv3

@GertjanReynaert
Copy link

@thymikee Thx for merging! Would you know when this fix would be available on NPM?

@thymikee
Copy link
Contributor

I don't have publish access, but working on it

@GertjanReynaert
Copy link

Thx for the efforts!!!

@thymikee
Copy link
Contributor

Published v1.0.2, let me know if it works

@GertjanReynaert
Copy link

I'll test it functionally in a bit, but I just tried installing that version:

  • with npm install it succeeds
  • wity yarn add it fails with this error

error https://github.com/react-native-community/react-native-push-notification-ios: Extracting tar content of undefined failed, the file appears to be corrupt: "Invalid tar header. Maybe the tar is corrupted or it needs to be gunzipped?"

Maybe this issue can be of any help? yarnpkg/yarn#3141

@thymikee
Copy link
Contributor

@GertjanReynaert use the package from npm:

yarn add @react-native-community/push-notification-ios

@GertjanReynaert
Copy link

@thymikee That's what I did:

❯ yarn add @react-native-community/push-notification-ios
yarn add v1.17.3
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
error https://github.com/react-native-community/react-native-push-notification-ios: Extracting tar content of undefined failed, the file appears to be corrupt: "Invalid tar header. Maybe the tar is corrupted or it needs to be gunzipped?"
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.

@thymikee
Copy link
Contributor

Yarn shouldn't fetch from GitHub by default, unless you tell it so. Can you remove the entry from yarn.lock and package.json and try again?

@GertjanReynaert
Copy link

Installing succeeded, indeed a problem on my side (removed the entry, removed yarn.lock, removed node_modules and yarn cache clean)

I'll give it a try in a few minutes, I'll let you know if I have any issues.

@GertjanReynaert
Copy link

My build succeeds, runs on my device, I'm able to trigger the permission modal and I receive a device token. I'd say it works, I'll test some more, but I think this build is good 👍

Thx for your efforts @thymikee !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The name of the given podspec RNCPushNotificationIOS doesn't match the expected one RNPushNotificationIOS
4 participants