-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename RNPushNotificationIOS.podspec to RNCPushNotificationIOS.podspec #15
Rename RNPushNotificationIOS.podspec to RNCPushNotificationIOS.podspec #15
Conversation
Avoid autolinking error with RN 60.
Please merge this! |
Thank you @Gp2mv3 |
@thymikee Thx for merging! Would you know when this fix would be available on NPM? |
I don't have publish access, but working on it |
Thx for the efforts!!! |
Published v1.0.2, let me know if it works |
I'll test it functionally in a bit, but I just tried installing that version:
Maybe this issue can be of any help? yarnpkg/yarn#3141 |
@GertjanReynaert use the package from npm:
|
@thymikee That's what I did:
|
Yarn shouldn't fetch from GitHub by default, unless you tell it so. Can you remove the entry from |
Installing succeeded, indeed a problem on my side (removed the entry, removed yarn.lock, removed node_modules and yarn cache clean) I'll give it a try in a few minutes, I'll let you know if I have any issues. |
My build succeeds, runs on my device, I'm able to trigger the permission modal and I receive a device token. I'd say it works, I'll test some more, but I think this build is good 👍 Thx for your efforts @thymikee ! |
Avoid autolinking error with RN 60.
Fixes #11
Summary
I had the error when linking the package in our project.
Test Plan
Compiles and executes fine.
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist